[Xen-devel] [PATCH] minios: fix and enforce block_domain atomicity

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>]

minios: fix and enforce block_domain atomicity

To ensure that the timer event is not lost, block_domain requires that
event delivery is disabled.  SCHEDOP_block re-enables them, so for
coherency (and fixing a bug actually), we should re-disable them after.
Also, make sure that the caller disabled them.

Signed-off-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx>

diff -r 4965e711fee8 extras/mini-os/arch/x86/time.c
--- a/extras/mini-os/arch/x86/time.c    Wed May 07 15:36:32 2008 +0100
+++ b/extras/mini-os/arch/x86/time.c    Thu May 08 11:40:05 2008 +0100
@@ -201,10 +201,12 @@ void block_domain(s_time_t until)
 {
     struct timeval tv;
     gettimeofday(&tv, NULL);
+    ASSERT(irqs_disabled());
     if(monotonic_clock() < until)
     {
         HYPERVISOR_set_timer_op(until);
         HYPERVISOR_sched_op(SCHEDOP_block, 0);
+        local_irq_disable();
     }
 }
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel