RE: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

["Liu, Jinsong" <jinsong.liu@xxxxxxxxx>]

Yes, thanks a lot! I will change it ASAP.

Regards,
Jinsong 

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
Sent: Tuesday, May 13, 2008 5:44 PM
To: Liu, Jinsong; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][PATCH 3/5] Add cpufreq pwr mgmt to Xen

On 13/5/08 10:34, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> I add a local variable 'a' in common/domain.c, since need to do '
> xen_processor_pmbits &= (~a);'
> If we directly use ' xen_processor_pmbits &= (~XEN_PROCESSOR_PM_PX)'
may
> result in some align issue if xen_processor_pmbits is not 32bits
> variable.
> So I add 'a' with same type as 'xen_processor_pmbits'.

If this is a concern then cast XEN_PROCESSOR_PM_PX before applying ~.
Actually the right thing will happen without that since
XEN_PROCESSOR_PM_PX
is a signed constant, so when the bitwise-negated value is widened it
will
be sign extended.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel