RE: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked

["Xu, Dongxiao" <dongxiao.xu@xxxxxxxxx>]

Hi, Ian,
    In your new patch, if find_protocol() function returns NULL, then you will 
let drv = &bdrv_raw, it is just guessing the image to be raw, I remember you 
mentioned it as a security problem. So I don't find any difference as the 
following one, it just reverts the change in block.c in C/S 17606. 

diff -r 86587698116d tools/ioemu/block.c
--- a/tools/ioemu/block.c       Wed May 14 14:12:53 2008 +0100
+++ b/tools/ioemu/block.c       Fri May 16 09:24:44 2008 +0800
@@ -254,7 +254,7 @@ static BlockDriver *find_protocol(const
 #endif
     p = strchr(filename, ':');
     if (!p)
-        return NULL; /* do not ever guess raw, it is a security problem! */
+        return &bdrv_raw;
     len = p - filename;
     if (len > sizeof(protocol) - 1)
         len = sizeof(protocol) - 1;



-----Original Message-----
From: Ian Jackson [mailto:Ian.Jackson@xxxxxxxxxxxxx] 
Sent: 2008年5月15日 19:08
To: Kevin Wolf
Cc: Xu, Dongxiao; Li, Haicheng; xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] VMX status report. Xen: #17630 & Xen0: #540 -- blocked

Could those of you having this problem please try the attached patch ?
I have tested this one much more thoroughly :-/.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel