RE: [Xen-devel] [PATCH 1/5] VT-d support for PV guests

[Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>]

[Allen M Kay]
> +    if ( !root_present(root_entry[bus]) )
>      {
> -        printk("---- print_vtd_entries %d ----\n", i++);
> +     unmap_vtd_domain_page(root_entry);
> +     printk("    root_entry[%x] not present\n", bus);
> +     return;
> +    } 

> Why is the indentation not working?  Are you using tabs instead of 4
> spaces for indentation?

Whoops.  Yeah.  It seems that the emacs local variables blob at the
end of the file was missing.  indent-tabs-mode was therefore set to
true.

        eSk




> It's good that you fixed print_vtd_entries().  I always wanted do
> that but never got high enough in the priority.

> Allen


>> -----Original Message-----
>> From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>> [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
>> Espen Skoglund
>> Sent: Monday, May 19, 2008 1:30 PM
>> To: xen-devel@xxxxxxxxxxxxxxxxxxx
>> Subject: [Xen-devel] [PATCH 1/5] VT-d support for PV guests
>> 
>> Page table debug output improvements
>> 
>> Signed-off-by: Espen Skoglund <espen.skoglund@xxxxxxxxxxxxx>
>> 
>> 


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel