Re: [Xen-devel] [PATCH] Remove physmap page upon granttab xfer

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Thu, May 29, 2008 at 11:15:31AM +0100, Keir Fraser wrote:
> 
> 
> 
> On 29/5/08 11:10, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
> 
> >> Thank you for explanation.
> >> The patch breaks ia64 granttab xfer breakage so that it have to be fixed.
> >> However the operation is now obsoleted one, so I don't want to make
> >> big effort to fix.
> >> What do you think about the following patch?
> > 
> > How does grant transfer work on ia64? Looking at netback I don't even see
> > how the 'hole' left by transfer of the old page gets filled by mapping in a
> > new page.
> 
> Oh, I see you do it steal_page(). Okay, I think best to make the
> remove_page() call ifndef ia64 then.

Thanks, here is the patch.

[IA64] fix ia64 granttab xfer.

On ia64 steal_page() also update the p2m table so that
guest_physmap_remove_page() call isn't necessary.
#ifndef out the call.

Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>

diff -r 74c35b543f27 xen/common/grant_table.c
--- a/xen/common/grant_table.c  Thu May 29 18:14:33 2008 +0900
+++ b/xen/common/grant_table.c  Thu May 29 19:23:07 2008 +0900
@@ -1112,7 +1112,9 @@
             goto copyback;
         }
 
+#ifndef __ia64__ /* on ia64 steal_page() also does remove_page() */
         guest_physmap_remove_page(d, gop.mfn, mfn, 0);
+#endif
 
         /* Find the target domain. */
         if ( unlikely((e = rcu_lock_domain_by_id(gop.domid)) == NULL) )


-- 
yamahata

Attachment: 03-granttab_xfer.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel