[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 2 of 4] paravirt: add hooks for ptep_modify_prot_start/commit



Ingo Molnar wrote:
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:

+#define  __HAVE_ARCH_PTEP_MODIFY_PROT_TRANSACTION

please turn this into CONFIG_ARCH_HAS_PTEP_MODIFY_PROT_TRANSACTION instead.

The __HAVE_ARCH_ form is consistent with all the other conditional things in asm/pgtable.h, like __HAVE_ARCH_PTEP_SET_ACCESS_FLAGS, __HAVE_ARCH_PTEP_TEST_AND_CLEAR_YOUNG, etc. I don't think adding CONFIG_ARCH_HAS_ for this one case is a good idea.

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.