[PATCH] Re: [Xen-devel] dom0 boot failure with 256G

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>   Trying to figure the hyp out, I notice phys addr is set as:
>
>   d->arch.physaddr_bitsize =
>           fls((1UL << 32) - HYPERVISOR_COMPAT_VIRT_START(d)) - 1
>             + (PAGE_SIZE - 2);
>   which is set to 0x1019, totally baffling me. I'd expect it to be 32,
>   36, or 64????????

Of course it should be PAGE_SHIFT in here! c/s 14097 screwed this up
- sorry, my fault.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2008-05-08/xen/arch/x86/domain.c
===================================================================
--- 2008-05-08.orig/xen/arch/x86/domain.c       2008-05-09 12:19:01.000000000 
+0200
+++ 2008-05-08/xen/arch/x86/domain.c    2008-06-05 09:31:30.000000000 +0200
@@ -353,7 +353,7 @@ int switch_compat(struct domain *d)
 
     d->arch.physaddr_bitsize =
         fls((1UL << 32) - HYPERVISOR_COMPAT_VIRT_START(d)) - 1
-        + (PAGE_SIZE - 2);
+        + (PAGE_SHIFT - 2);
 
     return 0;
 
Index: 2008-05-08/xen/arch/x86/domain_build.c
===================================================================
--- 2008-05-08.orig/xen/arch/x86/domain_build.c 2008-06-04 08:26:22.000000000 
+0200
+++ 2008-05-08/xen/arch/x86/domain_build.c      2008-06-05 09:31:36.000000000 
+0200
@@ -366,7 +366,7 @@ int __init construct_dom0(
     if ( is_pv_32on64_domain(d) )
         d->arch.physaddr_bitsize =
             fls((1UL << 32) - HYPERVISOR_COMPAT_VIRT_START(d)) - 1
-            + (PAGE_SIZE - 2);
+            + (PAGE_SHIFT - 2);
 #endif
 
     /*




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel