Re: [Xen-devel] [PATCH][TOOLS] libfsimage, pygrub, python: cleanup

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

On Fri, Jul 18, 2008 at 03:10:13PM +0100, Ian Jackson wrote:

> > >  fsi_plugin_ops_t *
> > > +fsi_init_plugin(int version, fsi_plugin_t *fp, const char **name);
> > > +
> > > +fsi_plugin_ops_t *
> > >  fsi_init_plugin(int version, fsi_plugin_t *fp, const char **name)
> 
> The purpose of -Wmissing-prototypes is to spot this situation:

Indeed.

> However if you don't understand this, you may do what the submitter of
> this patch did, which is to change a.c to read like this:
> 
>   a.c:  int function(void);
>         int function(void) { return 1; }
> 
> This completely defeats the point of -Wmissing-prototypes; I think
> it's just wrong.

It doesn't even make sense for the compiler to warn about the above
though. It's not called anywhere (that the compiler can detect:
certainly not in that C file).

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel