[Xen-devel] Re: [PATCH] x86: work around gcc 3.4.x bug

[Simon Horman <horms@xxxxxxxxxxxx>]

On Fri, Aug 08, 2008 at 01:46:07PM -0700, Jeremy Fitzhardinge wrote:
> gcc-3.4.x crashes when compiling pgd_prepopulate_pmd() when
> PREALLOCATED_PMDS == 0 and CONFIG_DEBUG_INFO is enabled.  This seems
> to avoid the problem.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> Cc: Adrian Bunk <bunk@xxxxxxxxxx>
> Cc: Simon Horman <horms@xxxxxxxxxxxx>
> Cc: Dhaval Giani <dhaval@xxxxxxxxxxxxxxxxxx>

Hi Jeremy,

This does solve the problem I was seeing on on 3.4.5.

Acked-by: Simon Horman <horms@xxxxxxxxxxxx>

> ---
> arch/x86/mm/pgtable.c |    3 +++
> 1 file changed, 3 insertions(+)
>
> ===================================================================
> --- a/arch/x86/mm/pgtable.c
> +++ b/arch/x86/mm/pgtable.c
> @@ -207,6 +207,9 @@
>       unsigned long addr;
>       int i;
>
> +     if (PREALLOCATED_PMDS == 0) /* Work around gcc-3.4.x bug */
> +             return;
> +
>       pud = pud_offset(pgd, 0);
>
>       for (addr = i = 0; i < PREALLOCATED_PMDS;
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel