[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 7 of 7] x86: always explicitly map acpi memory


  • To: "Jeremy Fitzhardinge" <jeremy@xxxxxxxx>
  • From: "Yinghai Lu" <yhlu.kernel@xxxxxxxxx>
  • Date: Sun, 7 Sep 2008 16:35:25 -0700
  • Cc: Ingo Molnar <mingo@xxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andi Kleen <andi@xxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>
  • Delivery-date: Sun, 07 Sep 2008 16:35:49 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=D9aSB9yk1eSImaXYRXvllzTFh9KEOBTza/ny2bBFV2tLy0fEHKnZroixw4vdI/oYLh 55j3F1p+YowlZlf0JEggIclAVxRdMqhXyYJJK5pJXmha8dYaHCWTeRo4+Ts59705zVIK m8bUedD8Z+N9pB+qfMS1R9q/Dz7Dzh390vU7k=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On Sun, Sep 7, 2008 at 3:21 PM, Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> Always map acpi tables, rather than assuming we can use the normal
> linear mapping to access the acpi tables.  This is necessary in a
> virtual environment where the linear mappings are to pseudo-physical
> memory, but the acpi tables exist at a real physical address.  It
> doesn't hurt to map in the normal non-virtual case, so just do it
> unconditionally.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>
> ---
>  arch/x86/kernel/acpi/boot.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -126,9 +126,6 @@
>
>        if (!phys || !size)
>                return NULL;
> -
> -       if (phys+size <= (max_low_pfn_mapped << PAGE_SHIFT))
> -               return __va(phys);
>
>        if (prev_map)
>                early_iounmap(prev_map, prev_size);
>

actually,
case 1: acpi tables near mmio, range, we don't map them from
2.6.27-rc1, and it is bigger than max_low_mapped...
case 2: some strange system put acpi in the middle of RAM... like when
8G ram installed, but MMIO is 3.5G, BIOS put acpi tables around 2G..

YH

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.