[Xen-devel] Re: [PATCH 6 of 7] x86: use early_ioremap in __acpi_map_table

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Ingo Molnar wrote:
> uhm, there's a nasty trap in that route: it can potentially cause a lot 
> of breakage.
>
> It's not robust to assume that the ACPI code is sane wrt. 
> mapping/unmapping, because it currently simply doesnt rely on robust 
> unmapping (in the linear range).
>
> I tried it in the past and i found tons of crappy ACPI code all around 
> that just never unmapped tables. Leaking ACPI maps are hard to find as 
> well, and it can occur anytime during bootup.
>   

Yes, you're right, it's a mess.  I put a unmap and warning in there, but
there's lots of acpi code which doesn't unmap after using its table.  It
doesn't seem to intermix using two tables, fortunately, so the "unmap
previous" behaviour of __acpi_map_table works OK, at least as far as I
can see.

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel