[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/4] CPUIDLE: Avoid remnant LAPIC timer intr while force hpetbroadcast



On 9/9/08 09:28, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

>> From above sequences, we can find this case will either introduce extra HPET
>> intrs or put off the softtimer expiring.
> This patch simply stops the LAPIC timer first (avoid immediate unnecessary
> expiring) and raise a softirq (continue the softtimer handling process, which
> will correct the LAPIC timer) when reprogram LAPIC timer fails.

It's not clear to me the disable/enable_LAPIC_timer() work is worthwhile for
the few timer interrupts it is likely to avoid. The other bit of the patch
is a good bugfix though. I've taken just the latter part.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.