[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Error in /etc/init.d/xendomains if using option XEN_DOMAINS_AUTO_ONLY=true - saving of the domains always fails / shutdown is called

Artur Linhart - Linux communication writes ("[Xen-devel] Error in 
/etc/init.d/xendomains if using option XEN_DOMAINS_AUTO_ONLY=true - saving of 
the domains always fails / shutdown is called"):
> for everybody who develops or uses the script /etc/init.d/xendomains, there
> is a serious error in this script.

Thanks for your report.

> [description]

You would appear to be correct and your proposed solution is very
nearly correct.  Thanks.

In general it would have been best if you had sent us a patch made
with `diff'.  For example,
   diff -u /etc/init.d/xendomains~ /etc/init.d/xendomains
   diff -u ~/xen-unstable.hg/tools/examples/init.d/xendomains 
or some such.  (The -u is important to produce the right output
format.)  You would probably find that easier than cutting and pasting
fragments of the two versions (with mysterious extra linebreaks, too)
and of course we can directly apply it.

Also, it would be usual to say
   Signed-Off-By: Your Name <your.email@xxxxxxxxxxxxxxxxxxx>
which indicates to us that you own the copyright in your contribution
and intend for your contribution to be made part of Xen and
distributed in the usual way.  Again, I think it's clear from your
message that this is the case and your proposed change is very small
so there is no need for that now.

I mention these things for the next time you wish to report a problem,
with a proposed fix, to a Free Software project.  Sending a patch made
with diff -u with an appropriated Signed-Off-By, is the best current
practice.  It makes life easier for everyone and will increase the
chances of the bug, that you're reporting, being fixed.

I have converted your suggested change to such a patch, and fixed up a
minor and probably irrelevant wrinkle with shell quoting.


Contributed-by: Artur Linhart <AL.LINUX@xxxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r fba8dca321c2 tools/examples/init.d/xendomains
--- a/tools/examples/init.d/xendomains  Thu Sep 11 11:58:08 2008 +0100
+++ b/tools/examples/init.d/xendomains  Thu Sep 11 12:21:59 2008 +0100
@@ -327,15 +327,17 @@ stop()
        if test $id = 0; then continue; fi
        echo -n " $name"
        if test "$XENDOMAINS_AUTO_ONLY" = "true"; then
-           case $name in
+           eval "
+           case \"\$name\" in
                    # nothing
-                   echo -n "(skip)"
+                   echo -n '(skip)'
+           "
        # XENDOMAINS_SYSRQ chould be something like just "s" 
        # or "s e i u" or even "s e s i u o"

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.