RE: [Xen-devel] [PATCH] x86,amd,microcode: fix hypercall return code

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Christoph Egger
>Sent: 2008年9月22日 20:23
>
>
>Hi,
>
>Attached patch makes the hypercall return failure
>if the microcode didn't apply.
>
>Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx>
>

It's weird that you don't add a 'break' if apply_microcode failed,
unless you're sure next invocation to get_next_ucode_from_buffer
_amd return 0... But even that, this is a bad coding style.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel