[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] RE: [PATCH] Share the IO_APIC_route_entry with iosapic

Hi Keir,
The iosapic continues to stay inside arch/ia64/; on the other hand, I think the 
struct 'IO_APIC_route_entry' should be placed to a common place so that IPF and 
x86 can share most of the common codes, like interrupt remapping.
To make the most use most use of the current x86 VT-d code, I personally think 
this movement of thedefinition of the struct IO_APIC_route_entry is necessary 
Could you please comment this more?

-- Dexuan

-----Original Message-----
From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx]
Sent: 2008年9月28日 17:36
To: Cui, Dexuan; 'xen-devel@xxxxxxxxxxxxxxxxxxx'
Subject: Re: [PATCH] Share the IO_APIC_route_entry with iosapic

If the code using this definition will be shared too, that's one thing. If
you're actually going to put all the code under arch/ia64 (which you seem to
imply), then duplicating this structure in include/asm-ia64 is okay. It's
not like it's changing, ever. I personally think that striving to share
architectural definitions in all cases, even where that may twist the header
#includes, is not necessarily a good idea. So it depends what your end goal

 -- Keir

On 28/9/08 07:52, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> The patch moves the struct IO_APIC_route_entry to a common place.
> This allows us to share the struct with iosapic.
> Thanks,
> -- Dexuan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.