Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH 0/3] IA64: add cpufreq support

[Isaku Yamahata <yamahata@xxxxxxxxxxxxx>]

On Thu, Oct 09, 2008 at 05:26:04PM +0800, Yu, Ke wrote:
> Isaku Yamahata wrote:
> > On Thu, Oct 09, 2008 at 11:37:23AM +0800, Yu, Ke wrote:
> >> Oh, looks like the BIOS is broken. From the  _PSS object , only the
> >> P0 state is valid, other two P states P1 and P2 are all zeros. This
> >> is not correct.
> >>
> >> Can you try another machine?
> >
> > Not only DSDT, but also MADE was broken,
> > I confirmed that xenpm worked by patching those tables. That's okay.
> >
> > Is it assumed that the dom0 acpi layer sees real
> > tables so that it understands all physical cpus?
> >
> > The assumption isn't true on xen/ia64.
> > Xen/ia64 modifies MADT to tell dom0 how many vcpu are assigned to
> > dom0. Please see acpi_update_lsapic() in
> > xen/arch/ia64/xen/dom_fw_dom0.c Something needs to be done.
> >
> > thanks,
> 
> Right, we already take this into consideration at the design phase. 
> Fortunately, Only the DSDT is needed for Px state, which is unmodifed, so 
> that is Ok for Px support.
> 
> And for the acpi id to apic id maping, we dedicatedly parse the MADT before 
> the acpi_update_lsapic, so the maping is also correct.

Great. I confirmed it myself.
I applied all your 3 patches.

thanks,
-- 
yamahata

_______________________________________________
Xen-ia64-devel mailing list
Xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-ia64-devel