[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] Linux support for hugepages as a Xen PVguest

>+static inline void set_huge_pte_at(struct mm_struct *mm, unsigned long addr, 
>pte_t *ptep, pte_t pteval) {
>+      if ((mm != current->mm && mm != &init_mm) ||
>+          HYPERVISOR_update_va_mapping(addr, pteval, 0))
>+              set_pmd((pmd_t *)ptep, (pmd_t){__pte_val(pteval)});

Your Xen patch made no attempt at implementing L2 modifications through
update_va_mapping, so why have the guest even try?

>+static inline pte_t huge_ptep_get_and_clear(struct mm_struct *mm, unsigned 
>long addr, pte_t *ptep)
>+      pte_t pte = *ptep;
>+      if (!pte_none(pte)) {
>+              if ((mm != &init_mm) ||
>+                  HYPERVISOR_update_va_mapping(addr, __pte(0), 0)) {
>+                      pte = *ptep;
>+                      set_pmd((pmd_t *)ptep, __pmd(0));

Same here.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.