Re: [Xen-devel] [PATCH][Retry 1] NextRIPS support for forthcoming AMD processors

["George Dunlap" <George.Dunlap@xxxxxxxxxxxxx>]

On Thu, Oct 16, 2008 at 3:47 PM, Mark Langsdorf <mark.langsdorf@xxxxxxx> wrote:
> +    switch (vmcb->exitcode)
> +    {
> +    case VMEXIT_CR0_READ... VMEXIT_DR15_WRITE:
> +        /* faults due to instruction intercepts */
> +        /* (exitcodes 84-95) are reserved */
> +    case VMEXIT_IDTR_READ ... VMEXIT_TR_WRITE:
> +    case VMEXIT_RDTSC ... VMEXIT_SWINT:
> +    case VMEXIT_INVD ... VMEXIT_INVLPGA:
> +    case VMEXIT_VMRUN ...  VMEXIT_MWAIT_CONDITIONAL:
> +    case VMEXIT_IOIO:
> +        /* ...and the rest of the #VMEXITs */
> +    case VMEXIT_CR0_SEL_WRITE:
> +    case VMEXIT_MSR:
> +    case VMEXIT_EXCEPTION_BP:
> +       return 1;
> +        break;
> +    default:
> +        return 0;
> +    }

Hmm... won't this giant case statement expand out into a huge string
of ifs?  It seems like we should be able to be more clever than that
for the common case.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel