[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 2/2] Fix and clean up vscsi_util.py and other files

Masaki Kanno writes ("[PATCH 2/2] Fix and clean up vscsi_util.py and other 
> Fix and clean up vscsi_util.py and other files
> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Thanks.  This looks like a definite improvement.  I think it should
make the vscsi stuff more or less harmless in situations where it's
not being used.

 Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

However, are you sure that the approach taken in vscsi_util.py is the
right one ?  The set of scsi devices available on a system may change
over time, so it is not correct to try to build a list at startup.
Also, doing so will slow down startup (including startup time of the
xm utility) on systems with many scsi devices even when pvscsi is not
in use, and exposes non-pvscsi users to bugs in the pvscsi system (as
previously discussed).

Surely there must be some way to do this lookup directly in /sys or
whereever at the point of use, when we're instructed to pass through a
specific device ?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.