RE: [Xen-devel] [PATCH] [VTD] Remove PCI device enumeration for dom0 in Xen

["Han, Weidong" <weidong.han@xxxxxxxxx>]

Espen Skoglund wrote:
> [Weidong Han]
>> Keir Fraser wrote:
>>> On 22/10/08 13:38, "Espen Skoglund" <espen.skoglund@xxxxxxxxxxxxx>
>>> wrote:
>>>> Users of pci_lock_pdev() and pci_lock_domain_pdev() would not be
>>>> able to find the PCI device unless it has been registered by dom0.
>>>> Apart from the iommu code, the only user affected would be the MSI
>>>> code which looks up the PCI device before enabling MSIs on it.  As
>>>> such, you would not be able to enable MSIs if you have an old dom0
>>>> kernel.
>>> 
>>> Is there any disadvantage to keeping this legacy code in Xen, apart
>>> from it annoyingly sitting there?
>>> 
> 
>> At present, I don't see any other disadvantage on functionality,
>> apart from it annoyingly sitting there and it allocates two pdev for
>> the same bdf.
> 
> Allocates two pdevs?  How?  alloc_pdev() will not allocate a new pdev
> if the bdf already exists.  It will just return the existing one.
> 

You are right, it won't allocate twice for one bdf. I made a mistake -:(

Regards,
Weidong



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel