Re: [Xen-devel] [PATCH 1/4] x86: add FIX_HOLE

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 27.10.08 13:06 >>>
>If no explanation can be given as to why this makes the highmem-assist patch
>work, I can only reasonably take neither patch.

Okay, okay, I recalled the problem after some staring at fixmap.h: The
BUG_ON() in virt_to_fix() would trigger on FIX_PAE_HIGHMEM_0 without
the hole, as fix_to_virt() on that index returns FIXADDR_TOP.

>On 27/10/08 11:38, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> I have to admit that I don't recall the exact details of where I ran
>> into a problem without this change, but it's a prerequisite for the
>> highmem-assist patch.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel