[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: fix domain cleanup

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Tue, 28 Oct 2008 10:49:33 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 28 Oct 2008 03:50:00 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Ack46tyFG1+8hKTeEd2ghgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] x86: fix domain cleanup

On 28/10/08 10:37, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> __put_page_type() is already a complex function actually, so let's define a
>> __put_final_page_type() containing a call to free_page_type() plus the
>> current tail of free_page_type(). __put_page_type() can call that;
>> relinquish memory can call free_page_type() directly.
> Will do it that way for submission. In testing it with that code inlined in
> __put_page_type(), I can confirm that this closes the memory leak, but
> it (obviously) doesn't address the crash when encountering a PGT_partial
> page hanging off of a page table being cleaned up by that explicit call
> to free_page_type() getting executed as a side effect of
> DOMAIN_DESTRUCT_AVOID_RECURSION. The question of course really
> is whether it's worthwhile trying to fix that, or rather to do away with it
> altogether by utilizing the 'real' preemption.

I don't actually understand the AVOID_RECURSION logic in
relinquish_memory(). I'd be delighted to get rid of it.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.