[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] cpufreq.c: shut up compiler about cpufreq_dom

Some versions of GCC are too stupid to figure out that cpufreq_dom is
only used if !!domexist and always set in that case, and complain that
it may be used uninitialised.

(In general it is IMO better to avoid these kind of flag
variables; I would prefer structures like
       for (...) { cpufreq_dom = dom;  if (...) goto cpufreq_dom_found; }
       cpufreq_dom = 0;
but on the other hand I don't like purely stylistic changes.)

Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

diff -r ae100f264f6a xen/drivers/cpufreq/cpufreq.c
--- a/xen/drivers/cpufreq/cpufreq.c     Wed Oct 29 13:09:37 2008 +0000
+++ b/xen/drivers/cpufreq/cpufreq.c     Wed Oct 29 16:41:14 2008 +0000
@@ -80,7 +80,7 @@ int cpufreq_add_cpu(unsigned int cpu)
     unsigned int dom, domexist = 0;
     unsigned int j;
     struct list_head *pos;
-    struct cpufreq_dom *cpufreq_dom;
+    struct cpufreq_dom *cpufreq_dom = 0;
     struct cpufreq_policy new_policy;
     struct cpufreq_policy *policy;
     struct processor_performance *perf = &processor_pminfo[cpu]->perf;

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.