[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86: fix preemptable page typehandling(v2)

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Thu, 30 Oct 2008 17:27:05 +0000
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 30 Oct 2008 10:27:18 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Ack6tLo/+Ov74aanEd2zLQAWy6hiGQ==
  • Thread-topic: [Xen-devel] [PATCH] x86: fix preemptable page typehandling(v2)

On 30/10/08 17:03, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>> This would be basically a small cmpxchg() loop. Since it's only executed
>> before setting PGT_partial we know that only one such special reference is
>> needed per page and we could just make get_page() leave headroom of one
>> reference.
>> Simpler code and faster code?
> Yes - admittedly I had expected you to dislike a special casing approach like
> this...

I think it will overall make the code clearer.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.