Re: [Xen-devel] grant table interface addition?

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 31/10/08 16:23, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

>>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 31.10.08 17:17 >>>
>> On 31/10/08 16:13, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>> 
>>>> GRANT_PTE_FLAGS should include _PAGE_GUEST_KERNEL then?
>>> 
>>> No, it should uniformly include neither _PAGE_USER nor _PAGE_GUEST_KERNEL.
>>> _PAGE_USER gets set when GNTMAP_application_map is specified, and
>>> based on this setting of _PAGE_USER, adjust_guest_l1e() will set either
>>> _PAGE_GUEST_KERNEL or _PAGE_GLOBAL.
>> 
>> The grant code doesn't use adjust_l1e() though.
> 
> Both create_grant_pte_mapping() and create_grant_va_mapping() do
> afaics.

Ah yes, indeed. Please send a patch to deal with this and _PAGE_NX.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel