[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] linux: prevent invalid or unsupportable PIRQs from being used


  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Wed, 05 Nov 2008 14:54:12 +0000
  • Cc:
  • Delivery-date: Wed, 05 Nov 2008 06:54:32 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Ack/Vl0xm4djyKtJEd2t7AAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] linux: prevent invalid or unsupportable PIRQs from being used

On 5/11/08 14:13, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> By keeping the respective irq_desc[] entries pointing to no_irq_type,
> setup_irq() (and thus request_irq()) will fail for such IRQs. This
> matches native behavior, which also only installs ioapic_*_type out of
> ioapic_register_intr().
> 
> At the same time, make assign_irq_vector() fail not only when Xen
> doesn't support the PIRQ, but also if the IRQ requested doesn't fall
> in the kernel's PIRQ space.

Reverted as it breaks the build non-trivially (at least: no
set_irq_chip_and_handler_name(); no pirq_chip structure). The 2.6.18 isn't
really the place for big code restructurings anyway (this was a big patch).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.