[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.



On 2008-11-06 09:17, Jens Axboe wrote:
> On Wed, Nov 05 2008, Keir Fraser wrote:
> > On 5/11/08 20:16, "Jens Axboe" <jens.axboe@xxxxxxxxxx> wrote:
> > 
> > >>> Does blkback propagate unplug events downwards?
> > >> 
> > >> Not sure what that means. blkback does its own limited queue plugging to 
> > >> try
> > >> to develop usefully schedulable batches of I/O. There's no concept of
> > >> plugging across the blkfront/blkback interface.
> > > 
> > > So once you leave your queuing loop, you unplug the below device? Or
> > > just point me at the source...
> > 
> > The tree's at http://xenbits.xensource.com/linux-2.6.18-xen.hg
> > 
> > You can clone it or browse it there.
> > 
> > The medium- to long-term issue is just to make sure that Jeremy's port of
> > blkback into upstream Linux (which he's probably working on at the moment)
> > doesn't perpetuate the bio violations. But I guess we should fix 2.6.18 too
> > since others base their own Xen patchsets on it still (e.g., for dom0
> > support).
> 
> Ah thanks! Perhaps we can talk Joe into snipping the bio_alloc() changes
> out of his patch #2 - Joe, just the bio_alloc() and submit_bio() stuff,
> you don't have to include the bio_set changes.
> 

Thanks, will get rid of it.

Joe



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.