Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.

[Joe Jin <joe.jin@xxxxxxxxxx>]

On 2008-11-06 12:07, Jens Axboe wrote:
> On Thu, Nov 06 2008, Keir Fraser wrote:
> > On 6/11/08 09:29, "Jens Axboe" <jens.axboe@xxxxxxxxxx> wrote:
> > 
> > >>> and be done with it.
> > >> 
> > >> Yes, I can put together a patch for that easily enough, I think.
> > > 
> > > Should be easy enough. Also be sure to defer any unplugging of the
> > > device until the very end, to still make a lot of room for merging and
> > > sorting.
> > 
> > http://xenbits.xensource.com/staging/linux-2.6.18-xen.hg c/s 723
> 
> Looks fine, but you can also get rid of the fail_put_bio and check for
> NULL return from bio_alloc(), since it'll never fail if you use
> GFP_KERNEL as the allocation mask. That's why you cannot nest
> allocations as well.
> 

OK, will take a testing for this patch, thanks all.

Joe



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel