Re: [Xen-devel] [PATCH] enable hpet after s3 resume

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 18/11/08 10:04, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

>> The hpet.c changes are ugly. What's so special about
>> hpet_broadcast_init()
>> that it needs to distinguish between boot and S3 resume? In
>> the latter case
>> it executes with APs still offline and IRQs disabled, so
>> what's wrong with
>> rewriting the fixmap entry, re-initialising the spinlock and hpet_event
>> info?
> 
> Is it safe to set fixmap entry twice without unmap? If yes, then
> agree same logic applies to both boot and S3 resume.

Yes, all it does is write a pte.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel