[Xen-devel] RE: [PATCH 2/2] resume hpet at s3 resume

["Tian, Kevin" <kevin.tian@xxxxxxxxx>]

>From: Keir Fraser [mailto:keir.fraser@xxxxxxxxxxxxx] 
>Sent: Tuesday, November 18, 2008 11:56 PM
>
>hpet_setup() is idempotent. We just need to be careful that
>hpet_broadcast_init() happens after any other caller of 
>hpet_setup(). That
>happens to be the case currently so I simplified your patch 
>considerably.
>Changeset 18787.
>

I'm not sure whether it's safe to call hpet_setup twice at boot
phase, though it may be ok for S3 resume case. hpet_setup 
will disable/enable hpet channel, and thus 2nd call may impact
system time a bit if hpet is taken as the clocksource (hpet 
counter is freezed when hpet is disabled)

Also regarding to 18786, there's inconsistency between platform
timer name and clocksource option, such as "ACPI PM TIMER"
and "acpi". Do you intend to use "clocksource=ACPI PM TIMER"
as boot option? If you really want to keep such full name, then
a speparate short name field can be introduced for comparison.

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel