[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [patch] netfront: unregister net device at backend_changed() if network_connect() failed


  • To: Joe Jin <joe.jin@xxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Wed, 19 Nov 2008 08:54:37 +0000
  • Cc: Xen-Devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Wed, 19 Nov 2008 00:55:00 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AclKJHNFsc+aRbYXEd2n/QAWy6hiGQ==
  • Thread-topic: [Xen-devel] Re: [patch] netfront: unregister net device at backend_changed() if network_connect() failed

On 19/11/08 02:13, "Joe Jin" <joe.jin@xxxxxxxxxx> wrote:

>> Have you actually seen this problem occur, in stress tests or elsewhere? Or
>> is this just a 'nice to have'? If the former I'd rather fix the bug!
>> 
> 
> At vm config file set vif type to ioemu and booting guest with pv driver,
> always saw the interface, unregister the device when network_connect(),
> I just saw one nic with 8139 driver.

I think failure to connect in frontend should always be a bug condition.

In this case, xend shouldn't be creating front and back directories at all.
What happens if you make netif's getDeviceDetails() return None for devid if
type == 'ioemu'? This should cause DevController.py not to set up the
front/back details and netfront.c will never get triggered.

Just need to make sure ioemu's netdevice still works. Including across
save/restore. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.