[Xen-devel] [PATCH] Fix device release for tap devices

[Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>]

Hi,

I saw the following error message when I shut down a domain.  The error 
message showed that release of device(vbd/51712) failed.  But the device 
was tap, was not vbd.  I think that a cause of the error message is 
because _releaseDevices() calls destroyDevice() by wrong device class.

[2008-11-26 10:29:21 5554] DEBUG (XendDomainInfo:946) 
XendDomainInfo.destroyDevice: deviceClass = vbd, device = vbd/51712
[2008-11-26 10:29:21 5554] ERROR (XendDomainInfo:1999) Device release failed: 
vm1; vbd; vbd/51712
Traceback (most recent call last):
  File "//usr/lib/python/xen/xend/XendDomainInfo.py", line 1994, in 
_releaseDevices
    self.destroyDevice(devclass, dev, False);
  File "//usr/lib/python/xen/xend/XendDomainInfo.py", line 960, in destroyDevice
    rc = self.getDeviceController(deviceClass).destroyDevice(devid, force)
  File "//usr/lib/python/xen/xend/server/blkif.py", line 187, in destroyDevice
    DevController.destroyDevice(self, devid, force)
  File "//usr/lib/python/xen/xend/server/DevController.py", line 228, in 
destroyDevice
    self.writeBackend(dev, 'online', "0")
  File "//usr/lib/python/xen/xend/server/DevController.py", line 474, in 
writeBackend
    raise VmError("Device %s not connected" % devid)
VmError: Device 51712 not connected

This patch fixes above problem.  By the patch, destroyDevice() is called 
by correct device class.

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Best regards,
 Kan

Attachment: releaseDevices.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel