[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Fix MMIO UARTs

Change set 982e6fce0e47 added an existence test for UARTs.
Unfortunately, the existence test happens before MMIO UARTs are
ioremapped, therefore it may not be probing where it thinks it's
probing.  Rather than moving more code around, I think it's probably
safe to assume the arch code knows what it's doing if it passes in an

Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>

diff -r a00eb6595d3c xen/drivers/char/ns16550.c
--- a/xen/drivers/char/ns16550.c        Sat Nov 29 09:07:52 2008 +0000
+++ b/xen/drivers/char/ns16550.c        Wed Dec 03 16:19:49 2008 -0700
@@ -303,6 +303,14 @@ static int check_existence(struct ns1655
     unsigned char status, scratch, scratch2, scratch3;
+     * We can't poke MMIO UARTs until they get I/O remapped later.
+     * Assume that if we're getting MMIO UARTs, the arch code knows
+     * what it's doing.
+     */
+    if (uart->io_base >= 0x10000)
+        return 1;
+    /*
      * Do a simple existence test first; if we fail this,
      * there's no point trying anything else.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.