RE: [Xen-devel] [PATCH][VTD] pci mmcfg patch for x86-64 - version 2

["Kay, Allen M" <allen.m.kay@xxxxxxxxx>]

I have moved the files into arch/x86 directory, added mmconfig_32.c but with 
pci_mmcfg_read/write() stubbed out - returning appropriate error values.

I will send out 3rd version after I fix a minor issue. 

Allen 

>-----Original Message-----
>From: Espen Skoglund [mailto:espen.skoglund@xxxxxxxxxxxxx] 
>Sent: Tuesday, December 09, 2008 4:41 AM
>To: Kay, Allen M
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx; Han, Weidong; Espen 
>Skoglund; Keir Fraser
>Subject: Re: [Xen-devel] [PATCH][VTD] pci mmcfg patch for 
>x86-64 - version 2
>
>I see that all the special pci mmcfg stuff has been put under the
>x86_64 tree.  However, most of it is generic x86.  Why not make the
>code mostly generic x86 and let the x86_32 specific part fail
>gracefully (as in: mmcfg not configured properly)?  Support for x86_32
>can then later be added without requiring code duplication or
>restructuring.
>
>        eSk
>
>
>[Allen M Kay]
>> Fixes made in version 2:
>> 1) Use PML4[257] for ioremap of PCI mmcfg.  As full 16-bit segment
>>    support would require 44-bits.  Since each slot only has 39-bits,
>>    we support 2048 PCI segments for now.  This can be easily
>>    expanded if deemed necessary in the future.
>
>> 2) Integrated PCI mmcfg access with existing PCI config interface
>>    for x86_64.  Use MMCFG interface if offset is greater than 256.
>
>> Signed-off-by: Allen Kay <allen.m.kay@xxxxxxxxx>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel