[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [HVM] enable MTF for guest single step debug

  • To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>, Xen Developers <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Thu, 11 Dec 2008 11:45:12 +0000
  • Cc:
  • Delivery-date: Thu, 11 Dec 2008 03:46:04 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AclbhezlH6dlArq46EGqP1//aD1IKw==
  • Thread-topic: [Xen-devel] [PATCH] [HVM] enable MTF for guest single step debug

On 11/12/2008 07:09, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> Monitor Trap Flag (MTF), is a debugging feature that cause vmexit on
> certain instruction boundaries, which can be used for HVM single step.
> We prefer MTF over TF, as it make TF free for guest use.
> This patch try to enable MTF for single step in gdb, and keep backward
> compatibility on old processor.
> Pls. see MTF details @ SDM 3b 21.7.2

Don't need EVENTTYPE_OTHER. Don't need to modify svm.c at all. The hvm_param
is gross since there is no obvious symmetric get() to go with your set() --
please just hack in a domctl, that'd be neater in this case imo even though
specific right now to x86 hvm.

That'll do for comments on patch v1... :-)

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.