[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH] x86: fix the potential of encounteringpanic "IO-APIC + timer doesn't work! ..."

>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 12.12.08 10:37 >>>
>On 12/12/2008 09:24, "Ingo Molnar" <mingo@xxxxxxx> wrote:
>>>> note that we had to revert that eventually. The real solution is an
>>>> array of fixes from Maciej spread out over many months.
>>> Does it do more harm than good on some systems, or is it simply not a
>>> comprehensive fix?
>> more harm than good - fixes some, breaks others. Have a look at the
>> latest upstream io_apic.c, that has it all settled down reasonably well.
>Thanks, Ingo.
>Jan: Do you agree we should revert the io_apic.c changes, but keep your
>addition of an explicit local_irq_enable() to __start_xen()?

No, please don't until Ingo clarified his indication of this having got
reverted (see my other response to him). I really can't see why properly
enabling/disabling interrupts in that code could do any harm.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.