[Xen-devel] Re: [PATCH] x86: fix the potential of encountering panic "IO-APIC+ timer doesn't work! ..."

[Ingo Molnar <mingo@xxxxxxx>]

* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:

> >>> Ingo Molnar <mingo@xxxxxxx> 12.12.08 10:13 >>>
> >
> >* Jan Beulich <jbeulich@xxxxxxxxxx> wrote:
> >
> >> >From all I can tell, the below reproduced full description of the
> >> original Linux patch applies to Xen, too - at least in the watchdog 
> >> enabled case IRQs can be enabled when entering setup_IO_APIC(). My 
> >> attention to this change really got caught just by the fact that it got 
> >> added to our (2.6.16-based) SLE10 kernel pretty recently.
> >
> >note that we had to revert that eventually. The real solution is an 
> >array of fixes from Maciej spread out over many months.
> 
> What do you mean by 'eventually'? 2.6.28-rc8 still has this code, and 
> so does -tip.

argh. Different io-apic breakage. I shouldnt remember patches by their 
subject lines ;-)

Sorry about the confusion - Jan is right and my fix ported to Xen is good 
;-)

the point about the other breakages remains: for the best bootup ratio 
you'll want to pick up everything from the (now unified) 
arch/x86/kernel/io_apic.c.

        Ingo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel