[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: about fixup_page_fault

On 17/12/2008 08:32, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

>> Consider copy_from_guest() applied to a PV guest with dirty
>> logging enabled.
>> The #PF handler should fix up faults when accessing guest
>> address space via
>> shadow page tables, even when the access happens within Xen.
> If Xen access guest address space intentionally like a hypercall
> parameter, such fix up is desired. However what about an random
> illegal access in Xen with faulting address happening to fall into
> guest address space?

Well, HVM guests obviously have a separate address space, so no issue there.
For a PV guest -- yes, Xen will then erroneously access guest address space
instead of crashing. But this is no worse than what would happen if running
without shadow page tables (i.e., dirty logging disabled). Fortunately Xen
has no bugs. ;-)

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.