[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: xc_translate_foreign_address() returns mfn??

  • To: "Tim Deegan" <Tim.Deegan@xxxxxxxxxx>
  • From: "Jun Koi" <junkoi2004@xxxxxxxxx>
  • Date: Sat, 20 Dec 2008 08:40:08 +0900
  • Cc: "List: Xen Developers" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 19 Dec 2008 15:40:42 -0800
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=uxRxJ+97V5vjZ5WFRFyCluBJJr/No1vTYJVvREslvzz/IZyDMnb63MM6GkImW3n9xt gZSz/YWjWCm54x1DH1JbrC+v1+Y8uimC71tjZRb+L2vP3jBnyjmFelk2F/V3EChl3/wq La+tHcdqJXvsdpHY+2Hvhq01Fj9IFuloSYBQo=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On Sat, Dec 20, 2008 at 2:13 AM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> Hi,
> At 23:38 +0900 on 19 Dec (1229729882), Jun Koi wrote:
>> So everything indicates that xc_translate_foreign_address() actually
>> returns gfn, not mfn like in its comment. Could anybody confirms that
>> the function works well on both PV and HVM?
> To the best of my knowledge that function does not work at all for HVM
> (at least, I know it is broken when using 32-bit tools and 64-bit xen).
> I have a half-done patchset that cleans it up considerably, fixing HVM
> and compat issues, which I'll probably post at the end of the month.
> In any case, you are right: these functions (like _almost_ every other
> interface dealing with guest memory) deals in what in the shadow code are
> called GFNs.  That is, untranslated GPFNs for HVM guests, and MFNs for PV.
> The use of "mfn" in the source code is probably an indicator that this
> code pre-dates HVM guest support.

That is a smart guess, I think :-)

And please fix the comment to reflect this in your new code.

Many thanks,

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.