[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] RE: [Xen-devel] Re: [patch 0/4]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs
O, sure. I will re-split the patch and fix it. Thanks for your suggestion! Thanks& Regards Criping -----Original Message----- From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Keir Fraser Sent: 2008年12月19日 22:50 To: Ke, Liping Cc: xen-devel@xxxxxxxxxxxxxxxxxxx Subject: [Xen-devel] Re: [patch 0/4]Enable CMCI (Corrected Machine Check Error Interrupt) for Intel CPUs On 19/12/2008 06:09, "Ke, Liping" <liping.ke@xxxxxxxxx> wrote: > Hi, All > > Following 4 patches are for enabling CMCI of Intel CPUs in XEN. These patches are a mess. You can't apply them one by one and build Xen at each intermediate step. Please properly divide into proper logical units. For example, the change to stop_machine_run(), and fixes to every caller, should be one single patch (probably the first patch). The patch to remove the old MCE stuff either needs to be in the same patch that adds the new support, or at least you need to fix up Makefiles etc so that applying that patch alone does not break the build. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |