[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel][PATCH] Revert Jan's patch (c/s 18879) since nowitcanbe achieved by xenpm tool now



>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 23.12.08 10:06 >>>
>On 23/12/2008 09:02, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:
>
>> It's fine to me to keep cmdline parse to select cpufreq governor.
>> I will update my patch, final result is:
>> 1. keep Jan's patch (c/s 18879);
>> 2. add governor setting at cmdline;
>> 3. set xen as default cpufreq;
>> 4. set userspace as default governor;
>> 5. if user set governor at cmdline --> if gov startup success, then cpufreq
>> run it; if gov startup fail, then cpufreq back to default safe governor;
>> Is it OK?
>
>Sounds fine to me. Let's see what Jan thinks too.

I'm okay with this too, though I'm not entirely clear why the userspace
governor would be safer/better than the performance one (in particular,
I'm unclear why the latter - supposedly not playing with frequencies at
all - has dependencies on certain tables to be loaded successfully). But
I admit that I didn't get around to look at the recent code changes, yet.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.