Xen project Mailing List

Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>

From: "Niraj Tolia" <ntolia@xxxxxxxxx>

Date: Tue, 6 Jan 2009 10:37:04 -0800

Delivery-date: Tue, 06 Jan 2009 10:37:29 -0800

Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=bcLZzy19C875jaVwoMpDlPFZ9DBYMQ0FhRXGqMWPrXwTuuNDTQks9/3r3pWiAnl4Oo zvXOSg8/ikKzyqMAhRmNGNuoWSFYvzAXDdAd0g/xSJrmgjQFy7NKiXIoNOCb8IIpZQeM LfZ4cd+bdIzDddL36M/CekAMd1xgwubstAfPA=

List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 06/01/2009 04:49, "Niraj Tolia" <ntolia@xxxxxxxxx> wrote:

> # HG changeset patch
> # User Niraj Tolia <ntolia@xxxxxxxxx>
> # Date 1231217146 28800
> # Node ID eb1ad7bbdaf3ae553a6bf319180b5880f5ac4307
> # Parent 8417ddc981b407753f966c568ef8c7b673d8d22a
> Xenoprof patch to fix the counter overflow check for CPUs with counter
> width > 32
>
> I had to port this patch from mainline Linux where it can be found at
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;
> h=7c64ade53a6f977d73f16243865c42ceae999aea
>
> Signed-off-by: Niraj Tolia <ntolia@xxxxxxxxx>

This patch can't possibly build, and is pointless anyway since the overflow

While the mainline patch won't build, the one attached definitely does. That said, I see your point about the overflow. Now I need to figure out why this broken patch actually enables xenoprof to work on my Intel Xeon. The only reason would be the switch from CTR_READ() (which uses rdmsr() internally) to rdmsrl() but let me dig into it.

Cheers,
Niraj

width check is still hardcoded to 32 bits in CTR_OVERFLOWED().

-- Keir

http://www.hpl.hp.com/personal/Niraj_Tolia/

_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel