[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] hvm_set_callback_irq_level() deadlock?


  • To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
  • Date: Wed, 07 Jan 2009 09:59:07 +0000
  • Cc:
  • Delivery-date: Wed, 07 Jan 2009 01:59:46 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AclwrpQ2M9m3LlgeeUSfLBM93bbKPA==
  • Thread-topic: [Xen-devel] hvm_set_callback_irq_level() deadlock?

On 07/01/2009 09:41, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx> wrote:

> hvm_set_callback_irq_level() and so on call vioapic_irq_positive_edge()
> before spin_unlock(&d->arch.hvm_domain.irq_lock).
> I think it cause a deadlock.
> If it is right, how should we fix them?
> What do you think?

Doesn't vioapic_irq_positive_edge() clearly expect to be called with that
lock held?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.