Re: [Xen-devel] Page fault for paravirtualization?

[Jun Koi <junkoi2004@xxxxxxxxx>]

On Fri, Jan 23, 2009 at 12:21 AM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:
> On 22/01/2009 14:55, "Jun Koi" <junkoi2004@xxxxxxxxx> wrote:
>
>> On Thu, Jan 22, 2009 at 7:21 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
>> wrote:
>>> We don't call paging_fault() for PV guests (unless doing live migration).
>>> Paging_mode_enabled() and paging_mode_external() will both return 0.
>>>
>>
>> Oops I skip that code, so missed it. Thanks!
>>
>> BTW, this code in xen/arch/x86/traps.c::fixup_page_fault() looks
>> suspicious: the VM_ASSIST check looks bogus. Is that dead code?
>
> No, we only emulate pagetable writes for PV guests if the guest wants us to.

I mean that the const VMASST_TYPE_writable_pagetables should be
exposed where it is set, as you can see that it is implicitly set
somewhere, and this is the only place we refer to it. So the code
looks very confused.

Thanks,
J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel