Re: [Xen-devel] [PATCH 2/2] ioemu: Enable guest OS to program D0-D3hot states of an assigned device

[Yuji Shimada <shimada-yxb@xxxxxxxxxxxxxxx>]

Thank you for your review.

On Wed, 4 Feb 2009 19:14:39 +0900
Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:

> On Tue, Feb 03, 2009 at 06:54:45PM +0900, Yuji Shimada wrote:
> > This patch enables guest OS to program D0-D3hot states of assigned
> > device.
> > 
> > Thanks,
> 
> Hi. Just a minor nit.
> 
> LIST_FOREACH() and LIST_FIRST() should be used instead
> of direct use of lh_first, le_next for consistency.

I agree with you that lh_first, le_next should not be used directly.

I will submit a new patch which uses LIST_FOREACH().

> Many "switch(len) case [124] pci_{read, write}_{byte, word, long}():"
> are duplicated. The duplication can be removed by using something like
> the followings (NOTE: I didn't compile it)

I found pci_{read, write}_block in libpci can be used to remove duplication.
I will make the patch use pci_{read, write}_block.

Thanks,
--
Yuji Shimada

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel