[Xen-devel] Re: [PATCH] x86: style fascism for xen assemblies

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

Tejun Heo wrote:
> Impact: style cleanup
>
> Make the following sytle cleanups.
>
> * drop unnecessary //#include from xen-asm_32.S
>   
Fine.
> * compulsive adding of space after comma
>   
Fine.
> * reformat multiline comments
>   
I don't really like what you've done here.  There are two problems:

   * If you're going to convert comments of the form

     /* This is a small comment which
        happens to be longer than a line. */
         

     then you should convert it to full winged-style, rather than just
     sticking '*' on the front of the second line.
   * All the big block comments look crowded and cramped now, which
     makes them harder to read and maintain.  All those '*'s are just
     visual noise. (They make a bit more sense in C code to distinguish
     comment from code, but asm code looks so different from comment
     that they're not necessary here.)

But Ingo's already pulled it, so I guess I'm stuck with it.

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel