[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 2] X86: cpufreq get_cur_val adjustment



>>> "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> 11.02.09 09:46 >>>
>X86: cpufreq get_cur_val adjustment
>
>c/s 19149 update cpufreq get_cur_val logic to avoid cross processor call, it's 
>a good point.
>However, to avoid null drv_data pointer, we adjust some logic in this patch, 
>to keep advantage of c/s 19149 and at same time
>to avoid null drv_data pointer.

Are you saying that there are cases where cpufreq_cpu_policy[cpu]->cpu != cpu?

And shouldn't drv_data[] be initialized for all known CPUs (possibly set to the 
same value for several of them)?

The patch you submitted would only be needed if the answer is 'yes' to the 
first question, and 'no' to the second (and even then I would think fixing 
drv_data[] initialization would be better than the patch presented here).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.