Re: [Xen-devel] [PATCH] passthrough: fix MSI-X table fixmap allocation

[Qing He <qing.he@xxxxxxxxx>]

On Mon, 2009-02-16 at 17:04 +0800, Keir Fraser wrote:
> On 16/02/2009 08:44, "Qing He" <qing.he@xxxxxxxxx> wrote:
> 
> > Currently, msix table pages are allocated a fixmap page per vector,
> > the available fixmap pages will be depleted when assigning devices with
> > large number of vectors.  This patch fixes it, and a bug that prevents
> > cross-page MSI-X table from working properly
> > 
> > Signed-off-by: Qing He <qing.he@xxxxxxxxx>
> 
> How does it fix it? Just a couple of sentences please, which I'll add to the
> changeset comment.

It now allocates msix table fixmap pages per device, if the table
entries of two msix vectors share the same page, it will only be
mapped to fixmap once. A ref count is maintained so that it can
be unmapped when all the vectors are freed.

Also changes the meaning of msi_desc->mask_base from the va of msix
table start to the va of the target entry. The former one is currently
bugged (it always maps the first page but msix can support up to 2048
entries) and can't handle separately allocated pages.

Thanks,
Qing

> 
>  -- Keir
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel