[Xen-devel] [PATCH ixgbe] Don't depend of skb->data for VMDq

[Mitch Williams <mitch.a.williams@xxxxxxxxx>]

Occasionally, vmq_alloc_skb() will give us an skb with a nonzero but
bogus data pointer.  Dereferencing this pointer will then cause a
panic.

Although we really need to find out where these are coming from, this
patch will enable us to continue development and testing in the short
term.

Signed-off-by: Mitch Williams <mitch.a.williams@xxxxxxxxx>

(Patch is attached as well as inline due to email mangling issues.)

diff -urpN -X dontdiff b/drivers/net/ixgbe/ixgbe_main.c
linux-2.6.18.hg/drivers/net/ixgbe/ixgbe_main.c
--- b/drivers/net/ixgbe/ixgbe_main.c    2009-02-17 13:48:00.000000000 -0800
+++ linux-2.6.18.hg/drivers/net/ixgbe/ixgbe_main.c      2009-02-17
14:06:58.000000000 -0800
@@ -1144,7 +1144,8 @@ static bool ixgbe_clean_rx_irq(struct ix
                total_rx_bytes += skb->len;
                total_rx_packets++;
 #ifdef CONFIG_XEN_NETDEV2_VMQ
-               if (skb->data)
+               if (!((adapter->flags & IXGBE_FLAG_VMDQ_ENABLED) &&
+                    rx_ring->queue_index))
 #endif
                        skb->protocol = eth_type_trans(skb, adapter->netdev);

Attachment: vmdq-bogus-skb-data.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel