Re: [Xen-devel] [PATCH] pygrub: make it work

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Frank van der Linden writes ("Re: [Xen-devel] [PATCH] pygrub: make it work"):
> It's been a while since I originally did this patch, so my memory is a 
> little rusty, but as far as I remember, I simply wanted to avoid 
> breaking Linux after an earlier version of the patch did so. I tested 
> the final version of the patch on Linux, and it worked fine. It could be 
> that the uname tests aren't needed anymore.

I think it would be better to have something that is the same
everywhere so I'd encourage you to resubmit without the special
casing (and I'll help fix it if it goes wrong).

Although Keir may disagree :-).

> Ian Jackson wrote:
> > Can you explain what the purpose of this new code is or relevantly how
> > it differs from the old (ie, what was wrong with the old code) ?
> 
> The comments I added explain it:
> 
> +    # The filedescriptors are NDELAY, so it's ok to try to read

Yes, that's a good explanation of the new code.  What seems to be
lacking is an explanation of what was wrong with the old code - ie,
what should go in the changeset comment.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel